Increased testing of nc4grp.c, fixed nc_rename_grp() duplicate name, NULL name bugs #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bunches of tests are failing on travis due to timeouts. GitHub has been timing out for me a lot too. Probably it's just a self-aware AI taking over our planet and using the bandwidth. So soon everything will be better run. But meanwhile, I will do another commit to trigger another round of travis testing. |
|
These changes are now part of #788 so I will close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took a look at the test coverage of nc4grp.c this morning, which was %75. This PR takes it up to a more respectable 90%.
While testing I found and fixed some bugs with nc_rename_grp() and names.
Fixes #785.
Fixes #784.
Fixes #783.
Fixes #782